Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test ClassLoader issue #16829

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix test ClassLoader issue #16829

merged 1 commit into from
May 4, 2021

Conversation

stuartwdouglas
Copy link
Member

This prevents the base runtime CL from
loading deployment classes.

Fixes #16810
Fixes #16804

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Apr 27, 2021
@Ladicek
Copy link
Contributor

Ladicek commented Apr 27, 2021

This basically uses the approach I proposed in https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Avro.20vs.2E.20continuous.20testing, where the base CL would throw CNFE for application classes? Nice! I didn't know it would be this easy, thanks :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building f1924d4

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@stuartwdouglas
Copy link
Member Author

When I added the flat-class-path I was running out of time to get CT into Alpha1, and did not realize that it would delegate to the TCCL if the original CL failed to look it up.

@gsmet
Copy link
Member

gsmet commented Apr 27, 2021

@stuartwdouglas the TCK failures look suspicious.

This prevents the base runtime CL from
loading deployment classes.

Fixes quarkusio#16810
Fixes quarkusio#16804
@gsmet gsmet merged commit 1111b9c into quarkusio:main May 4, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/grpc gRPC area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka / Avro class loader issue quarkus.test.flat-class-path=true required to run Avro tests
3 participants