Remove obsolete substitution for kafka snappy #16798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kafka 2.8.0 removes the `MethodHandle` usage in `CompressionType` (see apache/kafka#10123) removing `SnappyConstructors` as well. As a result the substitution is no longer valid. The update to Kafka 2.8.0 was done in quarkusio@f8ce993 Fixes quarkusio#16721
|
Marked as Draft until the workflow testing the fix with Mandrel 20.3 completes: https://github.com/graalvm/mandrel/actions/runs/784996770 |
zakkak
added
triage/waiting-for-ci
|
The tests look OK with in 20.3. |
gsmet
approved these changes
Apr 26, 2021
|
@famod @gsmet shouldn't the CI run the native-image tests for kafka in this PR? Update: ignore me, they are here https://github.com/quarkusio/quarkus/actions/runs/785202998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka 2.8.0 removes the
MethodHandleusage inCompressionType(see apache/kafka#10123) removingSnappyConstructorsas well. As a result the substitution is no longer valid.The update to Kafka 2.8.0 was done in f8ce993
Fixes #16721