-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to support inheritance in JAX-RS Resource included via Application#getClasses #16793
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 4e282fa
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 15 #📦 extensions/oidc-client-filter/deployment✖ 📦 extensions/oidc/deployment✖ ✖ ✖ ⚙️ Native Tests - Security2 #📦 integration-tests/oidc✖ |
Hi @geoand and @stuartwdouglas, WDYT of this PR and its corresponding ticket? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@geoand Hi, should I propose a backport for the version 1.13? |
Sure, go ahead and add the label. This should apply cleanly to the |
I don't have sufficient rights to add labels but here it is #16823 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 4e282fa
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/oidc-client-filter/deployment✖ 📦 extensions/oidc/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 15 #📦 extensions/oidc-client-filter/deployment✖ 📦 extensions/oidc/deployment✖ ✖ ✖ |
FYI The build failures don't seem to be related to this PR |
Same comment as #16823 (comment) :) |
4e282fa
to
ae36b2e
Compare
@geoand done too |
This one sounds good now |
fixes #16754
Motivation
If a JAX-RS Resource inherits a
@Path
annotation from an interface or a subclass and is included to the JAX-RS Application via the methodgetClasses
, it is actually ignored by the current implementation of a JAX-RS Application in the extension Resteasy Classic.Modifications:
@Path
annotations by checking concrete classes when the enclosing class of the annotation is an interface or an abstract class.Result
The inheritance of
@Path
annotations is now supported by the JAX-RS Application in the extension Resteasy Classic.