Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to support inheritance in JAX-RS Resource included via Application#getClasses #16793

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

essobedo
Copy link
Contributor

fixes #16754

Motivation

If a JAX-RS Resource inherits a @Path annotation from an interface or a subclass and is included to the JAX-RS Application via the method getClasses, it is actually ignored by the current implementation of a JAX-RS Application in the extension Resteasy Classic.

Modifications:

  • Improves the filter allowing to exclude @Path annotations by checking concrete classes when the enclosing class of the annotation is an interface or an abstract class.
  • Adds a dedicated test for it

Result

The inheritance of @Path annotations is now supported by the JAX-RS Application in the extension Resteasy Classic.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4e282fa

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 15 Build Test failures Logs Raw logs
Native Tests - Security2 Build Test failures Logs Raw logs
Native Tests - Security3 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 extensions/oidc-client-filter/deployment

io.quarkus.oidc.client.filter.OidcClientFilterDevModeTest.testGetUserName - More details - Source on GitHub

📦 extensions/oidc/deployment

io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.SecurityDisabledTestCase. - More details - Source on GitHub


⚙️ Native Tests - Security2 #

📦 integration-tests/oidc

io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testAccessAdminResourceCustomHeaderNoBearerScheme - More details - Source on GitHub

@essobedo
Copy link
Contributor Author

essobedo commented Apr 26, 2021

Hi @geoand and @stuartwdouglas, WDYT of this PR and its corresponding ticket?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@essobedo
Copy link
Contributor Author

@geoand Hi, should I propose a backport for the version 1.13?

@geoand
Copy link
Contributor

geoand commented Apr 27, 2021

Sure, go ahead and add the label.

This should apply cleanly to the 1.13 Branch

@essobedo
Copy link
Contributor Author

Sure, go ahead and add the label.

This should apply cleanly to the 1.13 Branch

I don't have sufficient rights to add labels but here it is #16823

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4e282fa

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc-client-filter/deployment

io.quarkus.oidc.client.filter.OidcClientFilterDevModeTest.testGetUserName - More details - Source on GitHub

📦 extensions/oidc/deployment

io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.SecurityDisabledTestCase. - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/oidc-client-filter/deployment

io.quarkus.oidc.client.filter.OidcClientFilterDevModeTest.testGetUserName - More details - Source on GitHub

📦 extensions/oidc/deployment

io.quarkus.oidc.test.CodeFlowDevModeDefaultTenantTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode - More details - Source on GitHub

io.quarkus.oidc.test.SecurityDisabledTestCase. - More details - Source on GitHub

@essobedo
Copy link
Contributor Author

FYI The build failures don't seem to be related to this PR

@geoand
Copy link
Contributor

geoand commented Apr 28, 2021

Same comment as #16823 (comment) :)

@essobedo essobedo force-pushed the 16754/add-inheritance-support branch from 4e282fa to ae36b2e Compare April 28, 2021 16:46
@essobedo
Copy link
Contributor Author

Same comment as #16823 (comment) :)

@geoand done too

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 28, 2021
@essobedo
Copy link
Contributor Author

This one sounds good now

@geoand geoand merged commit 81e8ea3 into quarkusio:main Apr 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 29, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 29, 2021
@essobedo essobedo deleted the 16754/add-inheritance-support branch April 29, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error from resources declared in javax.ws.rs.core.Application#getClasses
2 participants