Rest Client Reactive - fixed @RegisterProvider support #16757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalszynkiewicz
force-pushed
the
rest-client-reactive-fixes-for-providers
branch
from
383dac9 to
ce75636
Compare
|
👍🏼 I'll check it out on Monday |
geoand
reviewed
Apr 26, 2021
...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java
Outdated
Show resolved
Hide resolved
geoand
reviewed
Apr 26, 2021
...nt/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java
Outdated
Show resolved
Hide resolved
geoand
reviewed
Apr 26, 2021
| * @param generatedBeans build producer for generated beans | ||
| */ | ||
| @BuildStep | ||
| void registerProvidersFromAnnotations(CombinedIndexBuildItem indexBuildItem, |
There was a problem hiding this comment.
I am fairly certain that the generated class can be replaced by a synthetic bean which would make maintenance a lot easier
There was a problem hiding this comment.
I'll see if I can do that
There was a problem hiding this comment.
I created a version with synthetic bean: #16815
It has its own drawbacks: more code, usage of Class.forName and registering classes for reflection. I have a slight preference on this version but I don't mind if we merge the other.
There was a problem hiding this comment.
I prefer #16815, but it's up to you as this is your baby :)
There was a problem hiding this comment.
okay, let's go with this one then :)
If it's okay now, can you approve?
geoand
reviewed
Apr 26, 2021
michalszynkiewicz
force-pushed
the
rest-client-reactive-fixes-for-providers
branch
from
ce75636 to
0557762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #16702
Before the change, providers registered with the
@RegisterProviderannotation were registered in the generated stub, on the WebTarget. While this is enough for most non-MP-specific cases, it is not for microprofile ones, like ResponseExceptionMapper.This change introduces a new bean
AnnotationRegisteredProvidersthat stores information about the provider classes coming from annotations. This bean is used when a rest client stub is built withRestClientBuilderImpl.The info about the annotations is gathered at build-time. The bean has an abstract superclass to minimize the amount of generated bytecode.