Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prompt more consistent #16709

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 67ba17c

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b8506d9

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

@@ -16,9 +16,9 @@

private static final Logger log = Logger.getLogger("io.quarkus.test");

public static final String DISABLED_PROMPT = "\u001b[33mTests Disabled, press [e] to enable\u001b[0m";
public static final String PAUSED_PROMPT = "\u001b[33mTests pause, press [r] to resume\u001b[0m";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String PAUSED_PROMPT = "\u001b[33mTests pause, press [r] to resume\u001b[0m";
public static final String PAUSED_PROMPT = "\u001b[33mTests paused, press [r] to resume\u001b[0m";

@@ -37,7 +37,7 @@ public void install() {
public void handleInput(int[] keys) {
if (disabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be changed to paused?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but there is a different internal 'paused' that happens when a dev mode hot reload is going on (so you don't have the tests potentially slowing down user interaction).

@@ -130,7 +130,7 @@ public void testsEnabled() {
@Override
public void testsDisabled() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

Also fix incorrect reset code
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

Failing Jobs - Building 8e28f59

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 73 - More details - Source on GitHub

@stuartwdouglas stuartwdouglas merged commit 89130b4 into quarkusio:main Apr 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants