-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make prompt more consistent #16709
Make prompt more consistent #16709
Conversation
67ba17c
to
b8506d9
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 67ba17c
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b8506d9
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/jdbc/jdbc-mysql/deployment✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments.
@@ -16,9 +16,9 @@ | |||
|
|||
private static final Logger log = Logger.getLogger("io.quarkus.test"); | |||
|
|||
public static final String DISABLED_PROMPT = "\u001b[33mTests Disabled, press [e] to enable\u001b[0m"; | |||
public static final String PAUSED_PROMPT = "\u001b[33mTests pause, press [r] to resume\u001b[0m"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static final String PAUSED_PROMPT = "\u001b[33mTests pause, press [r] to resume\u001b[0m"; | |
public static final String PAUSED_PROMPT = "\u001b[33mTests paused, press [r] to resume\u001b[0m"; |
@@ -37,7 +37,7 @@ public void install() { | |||
public void handleInput(int[] keys) { | |||
if (disabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be changed to paused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but there is a different internal 'paused' that happens when a dev mode hot reload is going on (so you don't have the tests potentially slowing down user interaction).
@@ -130,7 +130,7 @@ public void testsEnabled() { | |||
@Override | |||
public void testsDisabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here?
Also fix incorrect reset code
b8506d9
to
8e28f59
Compare
Failing Jobs - Building 8e28f59
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/jdbc/jdbc-mysql/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ |
No description provided.