-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update file time once #16707
Only update file time once #16707
Conversation
41b5c29
to
99b933c
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 41b5c29
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 99b933c
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/resteasy-classic/resteasy/deployment✖ ✖ 📦 extensions/undertow/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/resteasy-classic/resteasy/deployment✖ ✖ 📦 extensions/undertow/deployment✖ ⚙️ JVM Tests - JDK 15 #📦 extensions/resteasy-classic/resteasy/deployment✖ ✖ 📦 extensions/undertow/deployment✖ ⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ |
99b933c
to
2f9c7bb
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2f9c7bb
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/jdbc/jdbc-mysql/deployment✖ |
Path path = copySourceFilesForClass(projectSourceRoot, deploymentSourcePath, testLocation, | ||
Path path = findTargetSourceFilesForPath(projectSourceRoot, deploymentSourcePath, testLocation, | ||
testLocation.resolve(sourceFile.getName().replace(".", "/") + ".class")); | ||
long old = modTime(path.getParent()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findTargetSourceFilesForPath
can return null
and you don't test it AFAICS. Maybe it's a corner case but it seems to be an open door for NPEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original copySourceFilesForClass could also return null. I will make them throw an exception instead.
@stuartwdouglas I'm not sure it's related to your work but this |
2f9c7bb
to
3117f96
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3117f96
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/jdbc/jdbc-mysql/deployment✖ 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖ ✖ ✖ ⚙️ JVM Tests - JDK 15 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖ ✖ ✖ |
I think DevServicesMySQLDatasourceTestCase.testDatasource is failing due to a JDK upgrade on the GH actions infrastructure. Should be fixed by #16746 |
Fixes issue with continous testing intermittent failures
3117f96
to
2cea672
Compare
@gsmet it would be good to get this in, it will hopefully fix the continuous testing intermittent failures. |
Fixes issue with continous testing intermittent failures