Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update file time once #16707

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

stuartwdouglas
Copy link
Member

Fixes issue with continous testing intermittent failures

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 41b5c29

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 99b933c

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldDisplayNewAddedFileIn404ErrorPage line 59 - More details - Source on GitHub

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldNotDisplayDeletedFileIn404ErrorPage line 78 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testAddResource line 127 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldDisplayNewAddedFileIn404ErrorPage line 59 - More details - Source on GitHub

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldNotDisplayDeletedFileIn404ErrorPage line 78 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testAddResource line 127 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldDisplayNewAddedFileIn404ErrorPage line 59 - More details - Source on GitHub

io.quarkus.resteasy.test.NotFoundExceptionMapperTestCase.shouldNotDisplayDeletedFileIn404ErrorPage line 78 - More details - Source on GitHub

📦 extensions/undertow/deployment

io.quarkus.undertow.test.devmode.ServletChangeTestCase.testAddResource line 127 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 791 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2f9c7bb

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

Path path = copySourceFilesForClass(projectSourceRoot, deploymentSourcePath, testLocation,
Path path = findTargetSourceFilesForPath(projectSourceRoot, deploymentSourcePath, testLocation,
testLocation.resolve(sourceFile.getName().replace(".", "/") + ".class"));
long old = modTime(path.getParent());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findTargetSourceFilesForPath can return null and you don't test it AFAICS. Maybe it's a corner case but it seems to be an open door for NPEs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original copySourceFilesForClass could also return null. I will make them throw an exception instead.

@gsmet
Copy link
Member

gsmet commented Apr 22, 2021

@stuartwdouglas I'm not sure it's related to your work but this DevServicesMySQLDatasourceTestCase.testDatasource started failing very recently. It could be a GH Action infra issue though.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3117f96

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testConsumerUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testConsumerUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.devmode.AmqpDevModeTest.testCodeUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testConsumerUpdate - More details - Source on GitHub

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate - More details - Source on GitHub

@stuartwdouglas
Copy link
Member Author

I think DevServicesMySQLDatasourceTestCase.testDatasource is failing due to a JDK upgrade on the GH actions infrastructure. Should be fixed by #16746

Fixes issue with continous testing intermittent failures
@stuartwdouglas
Copy link
Member Author

@gsmet it would be good to get this in, it will hopefully fix the continuous testing intermittent failures.

@gsmet gsmet merged commit 627218f into quarkusio:main Apr 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants