Skip caching Multi and log WARN message at build time #16706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenneg
force-pushed
the
skip-caching-multi
branch
from
e2a9ed8 to
11899a1
Compare
cescoffier
previously requested changes
Apr 25, 2021
|
You're right, the documentation needs an update. I'll take care of it. |
|
@gwenneg ping! |
gwenneg
force-pushed
the
skip-caching-multi
branch
from
11899a1 to
0ad3f33
Compare
gwenneg
force-pushed
the
skip-caching-multi
branch
from
0ad3f33 to
902c082
Compare
|
Can this PR be merged without the doc? As I mentioned in #22683, I'm working on a separate PR that will improve the quarkus-cache doc. The new version should cover all the important details about the integration with Mutiny, including this. |
gsmet
approved these changes
Jan 7, 2022
|
Yes, sure. |
gsmet
dismissed
cescoffier’s stale review
Doc will be addressed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, this PR prints a
WARNmessage in the log at build time when@CacheResultis used on a method returningMulti.I also updated
CacheResultInterceptorto stop caching theMulti.