Fix javadoc runs in kotlin module #16693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Apr 21, 2021
| <plugin> | ||
| <groupId>org.jetbrains.dokka</groupId> | ||
| <artifactId>dokka-maven-plugin</artifactId> | ||
| <version>0.10.1</version> | ||
| <version>1.4.30</version> |
There was a problem hiding this comment.
Does this have to be the same as the Kotlin version we use?
There was a problem hiding this comment.
That I don't know, maybe but I don't have the time to wait so it can be fixed later :).
There was a problem hiding this comment.
It does not. That's the latest version in central.
geoand
reviewed
Apr 21, 2021
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <version>3.1.1</version> |
There was a problem hiding this comment.
Do we need to specify a version here?
gsmet
approved these changes
Apr 21, 2021
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 4bb6bb1
|
Failing Jobs - Building a67f652
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment✖ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.