-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare input for quarkusGenerateCode gradle task #16672
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1d233b3
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Linux #📦 integration-tests/gradle✖ ✖ ✖ ✖ |
Path testSrc = src.resolve(SourceSet.TEST_SOURCE_SET_NAME); | ||
for (String codeGenerationSource : CODE_GENERATION_SOURCES) { | ||
sourcesDirectories.add(mainSrc.resolve(codeGenerationSource).toFile()); | ||
sourcesDirectories.add(testSrc.resolve(codeGenerationSource).toFile()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it makes sense to check whether these paths exist before adding them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or would it be too early at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think that's doable. I will need to do some refactoring, the generated code is not the default source set location (we have a subfolder per type of file: proto, avdl, ...) and thus, each generated java file needs to be registered to the compileJava task which is not the case when the task is UP-TO-DATE
..
@aloubyansky I updated the code to declare both input and output. I also check if the path exists before adding it to the |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building ee80391
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Linux #📦 integration-tests/gradle✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ |
@glefloch failures look related? |
Yes I need to update the assertions for two of the three failures and look at the third one. |
@aloubyansky could you have a look at this one? this should help fixing #13882 as generated source directory will be available from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought I approved it before. Thanks @glefloch
This declares the following directories as task input:
src/main/avro
src/main/proto
src/test/avro
src/test/proto
This allows to the task to be detected as
UP-TO-DATE
by gradle.close #16661