Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AsyncFile, Path. Added PathPart and FilePart #16653

Merged
merged 1 commit into from
May 17, 2021

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Apr 20, 2021

This is the 1.13 version of #15891

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 7b9fc5b

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 653a8e6

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Run RESTEasy Reactive TCK Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 resteasy-reactive-testsuite/tests

com.sun.ts.tests.jaxrs.spec.filter.interceptor.JAXRSClient0021.fileWriterClientInterceptorTest line 591 - More details - Source on GitHub

@geoand
Copy link
Contributor

geoand commented Apr 20, 2021

CI failure seems related

@FroMage
Copy link
Member Author

FroMage commented Apr 20, 2021

It seems related. But this is for client interceptors, and that damn test runs locally…

@FroMage
Copy link
Member Author

FroMage commented Apr 20, 2021

Ah, it's using the 1.13 branch of the TCK, I need to port the same fix there. Fine.

@FroMage
Copy link
Member Author

FroMage commented Apr 20, 2021

Restarting CI, but it should be fine now.

@geoand
Copy link
Contributor

geoand commented Apr 20, 2021

👍🏼

@geoand
Copy link
Contributor

geoand commented Apr 21, 2021

Still failing:

Error:  Failures: 
Error:    JAXRSClient0021.fileWriterClientInterceptorTest:591->JaxrsCommonClient.invoke:212 [WebValidatorBase] Unable to find the following search string in the server's response: 'com.sun.ts.tests.jaxrs.spec.filter.interceptor.EntityWriterInterceptor' at index: 0

@FroMage
Copy link
Member Author

FroMage commented Apr 21, 2021

Well yeah, the stupid thing still checked out the previous version: 0ce5dbc724a688ff94da4b5755c9720c70a2bf0d

@FroMage
Copy link
Member Author

FroMage commented Apr 21, 2021

So, restarted it again, but if it keeps taking the wrong commit, I don't know what to do.

@geoand
Copy link
Contributor

geoand commented Apr 21, 2021

If you pushed the TCK changes to the 1.13 branch, then CI should be fine because of https://github.com/quarkusio/quarkus/blob/1.13/.github/workflows/ci-actions-incremental.yml#L600

@FroMage
Copy link
Member Author

FroMage commented Apr 21, 2021

I did, and I checked it in github too. So either it's caching something, or I made a mistake I couldn't spot.

@geoand
Copy link
Contributor

geoand commented Apr 21, 2021

Let's see what happens :)

@geoand
Copy link
Contributor

geoand commented Apr 21, 2021

@gsmet this PR is against 1.13 as it's a feature we wanted to backport but that needed some work to adapt to Vert.x 3.9.x.
I assume we are OK to merge it?

@FroMage
Copy link
Member Author

FroMage commented Apr 21, 2021

Yay, it passed!

@geoand
Copy link
Contributor

geoand commented Apr 26, 2021

@gsmet I am going to merge this, OK?

@cescoffier
Copy link
Member

@geoand should this me merged?

@geoand
Copy link
Contributor

geoand commented May 17, 2021

I forgot about this one. Yes, I'm merging it, thanks!

@geoand geoand merged commit 2eaedf0 into quarkusio:1.13 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants