Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a possible NPE in devtools BuildFile #16636

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Fixed a possible NPE in devtools BuildFile #16636

merged 1 commit into from
Apr 20, 2021

Conversation

aloubyansky
Copy link
Member

Fixes #16580

@aloubyansky aloubyansky requested review from ia3andy and rsvoboda April 19, 2021 20:12
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c507390

Status Name Step Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 791 - More details - Source on GitHub

rsvoboda
rsvoboda approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPE concern is resolved, changes look safe to me, CI is green.

@geoand geoand merged commit 430f236 into quarkusio:main Apr 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

@ia3andy ia3andy Awaiting requested review from ia3andy

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.

devtools - BuildFile - possible NPE
3 participants
@aloubyansky @rsvoboda @geoand