Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isParentFirst method to QuarkusClassLoader #16617

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 19, 2021

This can be used by extensions to determine if a class
would be loaded parent first or not.
Relates to: #16576 (comment)

cc @mkouba

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Apr 19, 2021
@geoand geoand force-pushed the parent-frst-public branch from 1d48b75 to a4b923c Compare April 19, 2021 07:30
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1d48b75

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@mkouba mkouba requested a review from stuartwdouglas April 19, 2021 10:01
This can be used by extensions to determine if a class
would be loaded parent first or not.
Relates to: quarkusio#16576 (comment)
@geoand geoand force-pushed the parent-frst-public branch from a4b923c to 8485eee Compare April 20, 2021 11:06
@geoand
Copy link
Contributor Author

geoand commented Apr 20, 2021

Rebased onto main now that continuous testing is in

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8485eee

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 15 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 791 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

Failing Jobs - Building 8485eee

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/vault-agroal

io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

io.quarkus.vault.VaultKv1ITCase.crudSecretV1 line 35 - More details - Source on GitHub

@mkouba
Copy link
Contributor

mkouba commented Apr 21, 2021

Looks good. So for evey class that would be normally transformed to workaround a proxy limitation we'll check (only in the dev mode) whether QuarkusClassLoader#isParentFirst() returns false, otherwise we will fail the build...

@geoand
Copy link
Contributor Author

geoand commented Apr 21, 2021

@stuartwdouglas is this good with you?

@geoand geoand merged commit f659381 into quarkusio:main Apr 21, 2021
@geoand geoand deleted the parent-frst-public branch April 21, 2021 14:35
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 21, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 2.0.0.Alpha1 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants