Update the section about disabling security with a link to the TestSecurity doc #16591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey George - this is not an urgent PR to review :-) |
|
@cemnura Hi Cem, so yes, sorry about asking to fix the linked issue where it already works anyway with |
machi1990
reviewed
Apr 20, 2021
Co-authored-by: Manyanda Chitimbo <[email protected]>
|
@machi1990 thanks - your approval will be good as well as George is not available at the moment |
machi1990
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13205.
Add a link to the
TestSecuritydocs where it is well explained how to disable the sec checks - I thought of deleting this section where a custom interceptor is provided - but even if it did not work for OIDC at some point I recall a user was suggesting an improvement to the example code and it worked for them which I followed up with this PR so it makes sense to keep this hint.