Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that Vert.x runs in its dev-mode when Quarkus is started in dev-mode #16527

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Ensure that Vert.x runs in its dev-mode when Quarkus is started in dev-mode #16527

merged 1 commit into from
Apr 15, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 14, 2021

This prevents Vert.x from caching static resources

Fixes: #16524

@geoand geoand mentioned this pull request Apr 14, 2021
Closed
cescoffier
cescoffier approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, didn't know that trick.

@geoand
Copy link
Contributor Author

geoand commented Apr 14, 2021

Neither did I 🙈

stuartwdouglas
stuartwdouglas requested changes Apr 14, 2021
View reviewed changes
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just do System.setProperty() in VertxHttpHotReplacementSetup (which should happen before any Vert.x classes are loaded).

This way it will work from the IDE as well, and is in the extension where it belongs.

@geoand
Copy link
Contributor Author

geoand commented Apr 15, 2021

Can we just do System.setProperty() in VertxHttpHotReplacementSetup (which should happen before any Vert.x classes are loaded).

This way it will work from the IDE as well, and is in the extension where it belongs.

Sure thing. After I made the change I remembered that my change won't affect remote-dev so was planning on doing what you mention anyway

@geoand
Ensure that Vert.x runs in its dev-mode when Quarkus is started in de…
36f76f5 
…v-mode

This prevents Vert.x from caching static resources

Fixes: quarkusio#16524
@geoand geoand requested a review from stuartwdouglas April 15, 2021 05:19
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes area/devmode and removed area/vertx area/core labels Apr 15, 2021
@geoand geoand merged commit dbed19f into quarkusio:main Apr 15, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 15, 2021
@geoand geoand deleted the #16524 branch April 15, 2021 08:01
@famod
Copy link
Member

famod commented Apr 16, 2021

FTR, I had to reopen #16524.

@geoand
Copy link
Contributor Author

geoand commented Apr 16, 2021

Okay 👌

@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/devmode
Projects
None yet
Milestone
1.13.3.Final
Development

Successfully merging this pull request may close these issues.

DevMojoIT.testThatNewResourcesAreServed is flaky
5 participants
@geoand @famod @stuartwdouglas @cescoffier @gsmet