Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jboss-logging from 3.3.2.Final to 3.4.1.Final #16500

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2021

Bumps jboss-logging from 3.3.2.Final to 3.4.1.Final.

Release notes

Sourced from jboss-logging's releases.

JBoss Logging 3.4.1.Final

Release Notes - JBoss Logging - Version 3.4.1.Final

JBoss Logging 3.3.3.Final

Release Notes - JBoss Logging - Version 3.3.3.Final

Commits
  • e5e1364 Prepare for 3.4.1.Final release
  • 614df95 Merge pull request #32 from fl4via/JBLOGGING-141
  • d9dfaf3 [JBLOGGING-141] Invoke doPrivileged only if SecurityManager is not null
  • f7a0712 Merge pull request #31 from marschall/JBLOGGING-140
  • faad8b1 [JBLOGGING-140] Avoid ClassCastException in Slf4jLoggerProvider
  • 75327d3 Next is 3.4.1.Final
  • b1fbe5e Prepare for 3.4.0.Final release.
  • c2e2f3f Merge pull request #30 from jamezp/JBLOGGING-139
  • 414927d [JBLOGGING-139] Remove the deprecated annotations and deprecate the unused Pa...
  • 3dca1e3 Merge pull request #29 from jamezp/JBLOGGING-136
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Apr 14, 2021
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 14, 2021
@gsmet
Copy link
Member

gsmet commented Apr 14, 2021

@jamezp is it a safe upgrade for us?

@jamezp
Copy link
Contributor

jamezp commented Apr 14, 2021

There is one possible breaking change. The annotations that are part of org.jboss.logging:jboss-logging-annotations that have been deprecated in jboss-logging have been removed, https://issues.redhat.com/browse/JBLOGGING-139. Other than the changes are minor jboss-logging/jboss-logging@3.3.2.Final...3.4.1.Final

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good for 2.0. Let's merge. Thanks @jamezp !

@gsmet gsmet merged commit 777c444 into main Apr 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 14, 2021
@dependabot dependabot bot deleted the dependabot/maven/org.jboss.logging-jboss-logging-3.4.1.Final branch April 14, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants