Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App config parameter support for project creation #16476

Conversation

cristian-com
Copy link
Contributor

Fixes #12924

Draft commit for supporting a new parameter to set config properties that will end up in the application.yml/properties when creating a project either using maven plugin or cli.

Hi there,

Since this is my first fix I just want to make sure someone have a look before going any further. A couple of questions/notes:

  • I'm going to add the same property for CLI, just would be good if you check the property name "configProperties".

  • I'm updating documentation because there are some broken links (I'm guessing because of refactoring), I will also document the new parameter.

  • I'm creating the constant APP_CONFIG_PROPERTIES in both SmartConfigMergeCodestartFileStrategyHandler.java & ProjectGenerator.java. I can not see a common file where this definition makes more sense.

  • Since there is not support for maps in command line, I'm assuming a string with the below format should be enough.

prop1Key:prop1value, prop2Key:prop2value

  • I will add testing after the approach validation.

1- Should I add other parameter to change the property and key-value separator?
2- Splitter is marked as @beta, I can change it if that is an issue
3- I've done some testing with codestarts adding various extensions, I've seen that when writing the .properties there is not a specific order so properties that should be together are not. e.g

quarkus.log.console.json.date-format=YYYY-MM-dd HH:mm:ss
other.log.console.color=false
other.http.port=8700
other.http.cors=true
quarkus.log.console.json.exception-output-type=detailed-and-formatted
quarkus.log.console.json.pretty-print=true

Should I open a new issue for this ? or can I just fix it ?

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Apr 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly

This message is automatically generated by a bot.

@cristian-com cristian-com changed the title 12924:app-config-properties-parameter-support-maven-cli App config properties parameter support for project creation Apr 13, 2021
@cristian-com cristian-com marked this pull request as draft April 13, 2021 13:51
@ia3andy ia3andy self-requested a review April 13, 2021 13:55
@cristian-com cristian-com changed the title App config properties parameter support for project creation WIP: App config properties parameter support for project creation Apr 13, 2021
@cristian-com
Copy link
Contributor Author

Forgot to mentioned:

In case of conflicts with other properties coming from codestarts,

Fixes #12924

Draft commit for supporting a new parameter to set config properties that will end up in the application.yml/properties when creating a project either using maven plugin or cli.

Hi there,

Since this is my first fix I just want to make sure someone have a look before going any further. A couple of questions/notes:

  • I'm going to add the same property for CLI, just would be good if you check the property name "configProperties".
  • I'm updating documentation because there are some broken links (I'm guessing because of refactoring), I will also document the new parameter.
  • I'm creating the constant APP_CONFIG_PROPERTIES in both SmartConfigMergeCodestartFileStrategyHandler.java & ProjectGenerator.java. I can not see a common file where this definition makes more sense.
  • Since there is not support for maps in command line, I'm assuming a string with the below format should be enough.

prop1Key:prop1value, prop2Key:prop2value

  • I will add testing after the approach validation.

1- Should I add other parameter to change the property and key-value separator?
2- Splitter is marked as @beta, I can change it if that is an issue
3- I've done some testing with codestarts adding various extensions, I've seen that when writing the .properties there is not a specific order so properties that should be together are not. e.g

quarkus.log.console.json.date-format=YYYY-MM-dd HH:mm:ss
other.log.console.color=false
other.http.port=8700
other.http.cors=true
quarkus.log.console.json.exception-output-type=detailed-and-formatted
quarkus.log.console.json.pretty-print=true

Should I open a new issue for this ? or can I just fix it ?

Forgot to mentioned.

In case of conflicts with other properties coming from codestarts, the codestarts ones will stay so I don't know if I just log these conflicts.

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks great! beside a few suggestions..

@ia3andy ia3andy changed the title WIP: App config properties parameter support for project creation WIP: App config parameter support for project creation Apr 13, 2021
cristian-com added a commit to cristian-com/quarkus that referenced this pull request Apr 13, 2021
cristian-com added a commit to cristian-com/quarkus that referenced this pull request Apr 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3662319

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs
JVM Tests - JDK 8 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kotlin

io.quarkus.kotlin.maven.it.KotlinCreateMavenProjectIT.testProjectGenerationFromScratchForKotlin line 43 - More details - Source on GitHub

📦 integration-tests/scala

io.quarkus.scala.maven.it.ScalaCreateMavenProjectIT.testProjectGenerationFromScratchForScala line 44 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/kotlin

io.quarkus.kotlin.maven.it.KotlinCreateMavenProjectIT.testProjectGenerationFromScratchForKotlin line 43 - More details - Source on GitHub

📦 integration-tests/scala

io.quarkus.scala.maven.it.ScalaCreateMavenProjectIT.testProjectGenerationFromScratchForScala line 44 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kotlin

io.quarkus.kotlin.maven.it.KotlinCreateMavenProjectIT.testProjectGenerationFromScratchForKotlin line 43 - More details - Source on GitHub

📦 integration-tests/scala

io.quarkus.scala.maven.it.ScalaCreateMavenProjectIT.testProjectGenerationFromScratchForScala line 44 - More details - Source on GitHub


⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

📦 integration-tests/kotlin

io.quarkus.kotlin.maven.it.KotlinCreateMavenProjectIT.testProjectGenerationFromScratchForKotlin line 43 - More details - Source on GitHub

📦 integration-tests/scala

io.quarkus.scala.maven.it.ScalaCreateMavenProjectIT.testProjectGenerationFromScratchForScala line 44 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[1] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[2] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[3] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[4] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[5] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[6] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[1] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[2] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[3] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[4] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[5] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[6] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateCustomRESTEasyJavaProject line 82 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[1] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[2] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[3] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[4] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[5] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[6] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testGradleProjectGenerationFromScratchWithExtensions line 303 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithExtensions line 260 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithResource line 203 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationAsModuleWithExistingPomFileWithPackagingPom line 177 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithCustomDependencies line 337 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.generateNewProjectAndRun line 410 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch line 67 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testThatDefaultPackageAreReplaced line 376 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[1] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[2] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[3] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[4] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[5] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleProject(String, String)[6] line 62 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[1] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[2] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[3] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[4] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[5] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateGradleKotlinProject(String, String)[6] line 71 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateCustomRESTEasyJavaProject line 82 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[1] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[2] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[3] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[4] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[5] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectCodestartMojoIT.generateMavenProject(String, String)[6] line 52 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testGradleProjectGenerationFromScratchWithExtensions line 303 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithExtensions line 260 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithResource line 203 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationAsModuleWithExistingPomFileWithPackagingPom line 177 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratchWithCustomDependencies line 337 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.generateNewProjectAndRun line 410 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch line 67 - More details - Source on GitHub

io.quarkus.maven.it.CreateProjectMojoIT.testThatDefaultPackageAreReplaced line 376 - More details - Source on GitHub

@cristian-com cristian-com changed the title WIP: App config parameter support for project creation App config parameter support for project creation Apr 15, 2021
@cristian-com cristian-com marked this pull request as ready for review April 15, 2021 12:01
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 62264f0

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@cristian-com cristian-com changed the title App config parameter support for project creation WIP:App config parameter support for project creation Apr 20, 2021
@cristian-com cristian-com changed the title WIP:App config parameter support for project creation App config parameter support for project creation Apr 21, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b20dbfa

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 276 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 276 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 276 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9b798a5

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 277 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 277 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 277 - More details - Source on GitHub

@ia3andy
Copy link
Contributor

ia3andy commented Apr 22, 2021

Could you squash it one commit please :)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ecb033b

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 279 - More details - Source on GitHub

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 279 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 devtools/cli

io.quarkus.cli.CliTest.testCreateWithAppConfig line 279 - More details - Source on GitHub

@cristian-com cristian-com changed the title App config parameter support for project creation WIP:App config parameter support for project creation Apr 22, 2021
@ia3andy
Copy link
Contributor

ia3andy commented Apr 30, 2021

@cristian-com could you squash to one commit and rebase from main please

@cristian-com cristian-com force-pushed the feature/12924-app-config-properties-maven-cli branch 2 times, most recently from 5e3eda7 to 17101b6 Compare May 1, 2021 13:14
@cristian-com
Copy link
Contributor Author

@cristian-com could you squash to one commit and rebase from main please

@ia3andy Done, I’ll check the rebase is right

…ation.yml/properties when creating a project either using maven plugin or cli.
@cristian-com cristian-com force-pushed the feature/12924-app-config-properties-maven-cli branch from 21e3fd5 to 6102113 Compare May 3, 2021 00:09
@cristian-com cristian-com changed the title WIP:App config parameter support for project creation App config parameter support for project creation May 3, 2021
@ia3andy
Copy link
Contributor

ia3andy commented May 3, 2021

I am giving it a try while the CI is running..

Very nice PR and good feature @cristian-com thanks!!!

@ia3andy
Copy link
Contributor

ia3andy commented May 3, 2021

Ok it works very well and it is pretty cool!

@cristian-com It would be nice if you could also add this option to the Quarkus Maven plugin in CreateProjectMojo in another PR.

EDIT: it's already there, so never mind thanks..

@cristian-com
Copy link
Contributor Author

Ok it works very well and it is pretty cool!

@cristian-com It would be nice if you could also add this option to the Quarkus Maven plugin in CreateProjectMojo in another PR.

EDIT: it's already there, so never mind thanks..

Nice, thanks for checking.

@quarkus-bot
Copy link

quarkus-bot bot commented May 3, 2021

Failing Jobs - Building 6102113

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-rest-client-reactive

org.eclipse.microprofile.rest.client.tck.InvokeWithJsonPProviderTest.testPutExecutes line 101 - More details - Source on GitHub

@cristian-com
Copy link
Contributor Author

cristian-com commented May 3, 2021

@ia3andy there is one test failing, I'm guessing it is not related, it seems like some kind of timeout. I can not see an option to re-run only that job. could you suggest how to proceed then ?

@ia3andy ia3andy merged commit 7d9fb9e into quarkusio:main May 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 3, 2021
@ia3andy
Copy link
Contributor

ia3andy commented May 3, 2021

Great Job!

@cristian-com cristian-com deleted the feature/12924-app-config-properties-maven-cli branch May 4, 2021 10:50
@ebullient
Copy link
Member

ebullient commented May 7, 2021

ok. I'm reorganizing the cli.. quite a bit for 2.x (as Andy is aware, see #16407 .. )
How is this expected to be used? (why wouldn't you just add these properties after the project is created?)
(to be clear, this is specifically regarding the cli.. not the maven plugin). I'm tempted to drop it from the updated CLI as something a little beyond what is necessary (background tooling can definitely use it! but I'm not sure the CLI itself does).

@cristian-com
Copy link
Contributor Author

ok. I'm reorganizing the cli.. quite a bit for 2.x (as Andy is aware, see #16407 .. )
How is this expected to be used? (why wouldn't you just add these properties after the project is created?)
(to be clear, this is specifically regarding the cli.. not the maven plugin). I'm tempted to drop it from the updated CLI as something a little beyond what is necessary (background tooling can definitely use it! but I'm not sure the CLI itself does).

Hey, the original issue is for the maven plugin actually. Based on this comment I also added to CLI #12924 (comment)

In my opinion, I see it quite handy when you want to add one-two properties when creating a new project, for more than that its just better to add the props directly to the file after created.

@ia3andy
Copy link
Contributor

ia3andy commented May 10, 2021

@ebullient this was a feature request by the community. I think it's really nice to be able to have the config ready when generating an app. The config is really powerful in Quarkus and is key to many of our extensions.

@ebullient
Copy link
Member

@ebullient this was a feature request by the community. I think it's really nice to be able to have the config ready when generating an app. The config is really powerful in Quarkus and is key to many of our extensions.

Right. As noted above, the feature requested by the community was for maven (and backend things), and I could see that being used inside a bazillion other tools, so I have no issue w/ that. It is specifically CLI usage that I'm asking about (which was an amendment/suggestion by Max, and not the original request).

@ia3andy
Copy link
Contributor

ia3andy commented May 10, 2021

@ebullient I am not sure if this has changed, but if I remember well, we should as much as possible have the same features in CLI and Maven plugin (cc @maxandersen).

Creating a project using Maven or CLI should be as similar as possible IMHO.

@ebullient
Copy link
Member

It's a matter of option flood / recommended practices. The CLI and maven/gradle build tools will/may drift based on capability/usability requirements (CLI does not need to / should not always emulate what maven/gradle do. I'm not saying they will drift hugely, but I am leaving room for change, e.g. buildless).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin should be able to create a project with properties
4 participants