Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - remove deprecated annotations from the io.quarkus.qute.api pkg #16468

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 13, 2021

No description provided.

@mkouba mkouba added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Apr 13, 2021
@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Apr 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 6cfb6cd

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
🚫 Native Tests - Windows - ${{ matrix.category }}

@mkouba mkouba force-pushed the qute-remove-deprecated-api-ann branch from 6cfb6cd to 65491bc Compare April 13, 2021 11:35
@mkouba mkouba added this to the 2.0 - main milestone Apr 13, 2021
@mkouba mkouba merged commit 8b67037 into quarkusio:main Apr 13, 2021
@rsvoboda
Copy link
Member

This is breaking mailer-quickstart, we will update it to use new API.
But this change should be labeled as breaking change imho so the users get notified about it. @mkouba

@mkouba
Copy link
Contributor Author

mkouba commented Apr 14, 2021

This is breaking mailer-quickstart, we will update it to use new API.
But this change should be labeled as breaking change imho so the users get notified about it. @mkouba

Yes, it definitely should be. In fact, any change that removes deprecated API is ;-).

kshpak added a commit to kshpak/quarkus-quickstarts that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/qute The template engine area/rest release/breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants