Upgrade to Hibernate Search 6.0.3.Final #16467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
@gsmet Ready for review; I released Hibernate Search 6.0.3.Final and it should be available in Maven Central soon. |
gsmet
approved these changes
Apr 13, 2021
|
Let's wait for the sync to Central. |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 9ed7581
|
It causes weird errors when mass indexing, probably because the MethodHandles implementation in native mode is not completely thread-safe. For example: Entities that could not be indexed correctly: Person#212 : org.hibernate.search.util.common.SearchException: HSEARCH900005: Exception while invoking 'private java.lang.Long io.quarkus.it.hibernate.search.elasticsearch.search.Person.id' on 'io.quarkus.it.hibernate.search.elasticsearch.search.Person@33be79fb'. ... Caused by: java.lang.ClassCastException: io.quarkus.it.hibernate.search.elasticsearch.search.Address cannot be cast to io.quarkus.it.hibernate.search.elasticsearch.search.Person
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #16463, and provides a workaround for Hibernate Search, but does not fix the problem entirely: we would need a fix in ORM for that.
CC @gsmet
Creating as draft: we need a release of Hibernate Search first; one that includes hibernate/hibernate-search#2544 (HSEARCH-4211) . I tested that the upgrade fixes the problem locally.