Qute checked templates - require type-safe expressions by default

[mkouba]

• related to Non-existing template variable not reported by Qute #14534

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cb56ccc

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 15
✖	JVM Tests - JDK 8	Build	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/scheduler/deployment

✖ io.quarkus.scheduler.test.PropertyDefaultValueSchedulerTest.testDefaultIdentity line 33 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cb56ccc

Status	Name	Step	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 11 Windows
✖	JVM Tests - JDK 15	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 8	Build	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0fec673

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Devtools Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	Devtools Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Linux	Build	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Windows	Verify dependencies	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 15	Build	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 8	Build	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11	Build	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	Verify with Maven	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Amazon		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Cache		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data1	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data2	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data3	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data4	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data5	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data6	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security1	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2	Reclaim Disk Space	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Windows - hibernate-validator	Build	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

[gastaldi]

LGTM

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0fec673

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 15	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 8	Build	Test failures	Logs	Raw logs
⌛	Native Tests - Messaging	Build	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 8 #

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.SaslKafkaConsumerTest.testReception line 48 - More details - Source on GitHub

✖ io.quarkus.it.kafka.SslKafkaConsumerTest.testReception line 56 - More details - Source on GitHub

[FroMage]

I'm late reviewing this, sorry, but this is nice and moves in the right direction.

I do wonder if we'll need something extra for side-loaded arguments.

Let me explain: quite often I've found myself to have a set-up where I have a main template (main.html), and then specialised templates (order.html, confirm.html) which extend it.

The specialised templates would be checked and take a list of type-checked arguments. The main template however can use variables that are optional, or so global that they're set by adding them to the renderArgs (in Play, it's a request-scoped map where you can add stuff passed to templates if ever one is rendered during the request) which you can access even from filters, not necessarily where you decide which template to render.

So for example, the currently logged-in user, or the notification messages would be such cases.

Perhaps in the case of Qute we can pass them to the main template differently. Perhaps not and we might need a way to declare them, without having to duplicate them on every checked-template, and passing them explicitely there. We also need a way to pass them.

Anyway, this is not for now, but I thought it's relevant so I'll mention it and we can think about this later when someone requests a feature like this.

[mkouba]

Hm, so right now each template is validated separately. E.g. the extended template main.html can have its own param declarations but parameters of a @CheckedTemplate method whose template extends the main.html do not contribute to this set. But yes, we could try to improve this if there is a feature request like this...