Avoid unnecessary exception wrapping in NativeTestExtension.throwBootFailureException #16440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Apr 12, 2021
| @@ -151,10 +151,15 @@ public void postProcessTestInstance(Object testInstance, ExtensionContext contex | |||
| } | |||
| } | |||
|
|
|||
| private void throwBootFailureException() { | |||
| private void throwBootFailureException() throws Exception { | |||
There was a problem hiding this comment.
Note that the method calling this is already throwing Exception so we are perfectly safe doing it here.
geoand
approved these changes
Apr 12, 2021
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a detail but by doing this we get rid of one level of nesting in most cases.
(noticed while trying to improve the bot situation)