Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all RESTEasy Reactive configuration under 'quarkus.resteasy-reactive' #16310

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 7, 2021

For the time being, the old quarkus.rest config root is still supported,
but that support will be removed once the vertx-4 branch has been merged
into main (at which point the TCK will be updated to use the new values).

However the old quarkus.security.jaxrs.deny-unannotated-endpoints is not
supported

…tive'

For the time being, the old 'quarkus.rest' config root is still supported,
but that support will be removed once the 'vertx-4' branch has been merged
into main (at which point the TCK will be updated to use the new values).

However the old 'quarkus.security.jaxrs.deny-unannotated-endpoints' is not
supported
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 7, 2021
gsmet
gsmet previously requested changes Apr 7, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the merge of 2.0 before merging that, please.

@geoand
Copy link
Contributor Author

geoand commented Apr 7, 2021

Let's wait for the merge of 2.0 before merging that, please.

Sure yeah

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 7, 2021

Failing Jobs

Status Name Failing step Test failures Logs Raw logs
Gradle Tests - JDK 11 Linux Build Logs Raw logs
Gradle Tests - JDK 11 Windows Verify dependencies Logs Raw logs
JVM Tests - JDK 11 Build Logs Raw logs
JVM Tests - JDK 11 Windows Build Logs Raw logs
JVM Tests - JDK 15 Build Logs Raw logs
JVM Tests - JDK 8 Build Logs Raw logs
MicroProfile TCKs Tests Verify with Maven Logs Raw logs
Native Tests - Amazon `` Logs Raw logs
Native Tests - Cache `` Logs Raw logs
Native Tests - Data1 Build Logs Raw logs
Native Tests - Data2 Build Logs Raw logs
Native Tests - Data3 Build Logs Raw logs
Native Tests - Data4 Build Logs Raw logs
Native Tests - Data5 Build Logs Raw logs
Native Tests - HTTP `` Logs Raw logs
Native Tests - Messaging `` Logs Raw logs
Native Tests - Misc1 `` Logs Raw logs
Native Tests - Misc2 `` Logs Raw logs
Native Tests - Misc3 `` Logs Raw logs
Native Tests - Misc4 `` Logs Raw logs
Native Tests - Security2 `` Logs Raw logs
Native Tests - Security3 `` Logs Raw logs
Native Tests - Spring `` Logs Raw logs
Native Tests - gRPC `` Logs Raw logs

@geoand
Copy link
Contributor Author

geoand commented Apr 7, 2021

Failing Jobs

Status Name Failing step Test failures Logs Raw logs
hourglass Gradle Tests - JDK 11 Linux Build Logs Raw logs
hourglass Gradle Tests - JDK 11 Windows Verify dependencies Logs Raw logs
hourglass JVM Tests - JDK 11 Build Logs Raw logs
hourglass JVM Tests - JDK 11 Windows Build Logs Raw logs
hourglass JVM Tests - JDK 15 Build Logs Raw logs
hourglass JVM Tests - JDK 8 Build Logs Raw logs
hourglass MicroProfile TCKs Tests Verify with Maven Logs Raw logs
hourglass Native Tests - Amazon [Logs](https://github.com/quarkusio/quarkus/runs/2286413155?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413155/logs) hourglass Native Tests - Cache Logs Raw logs
hourglass Native Tests - Data1 Build Logs Raw logs
hourglass Native Tests - Data2 Build Logs Raw logs
hourglass Native Tests - Data3 Build Logs Raw logs
hourglass Native Tests - Data4 Build Logs Raw logs
hourglass Native Tests - Data5 Build Logs Raw logs
hourglass Native Tests - HTTP [Logs](https://github.com/quarkusio/quarkus/runs/2286413256?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413256/logs) hourglass Native Tests - Messaging Logs Raw logs
hourglass Native Tests - Misc1 [Logs](https://github.com/quarkusio/quarkus/runs/2286413297?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413297/logs) hourglass Native Tests - Misc2 Logs Raw logs
hourglass Native Tests - Misc3 [Logs](https://github.com/quarkusio/quarkus/runs/2286413349?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413349/logs) hourglass Native Tests - Misc4 Logs Raw logs
hourglass Native Tests - Security2 [Logs](https://github.com/quarkusio/quarkus/runs/2286413079?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413079/logs) hourglass Native Tests - Security3 Logs Raw logs
hourglass Native Tests - Spring [Logs](https://github.com/quarkusio/quarkus/runs/2286413394?check_suite_focus=true) [Raw logs](https://github.com/quarkusio/quarkus/commit/68fcdea45cb75eb4d8412ef3e3a29ce6cc3e3778/checks/2286413394/logs) hourglass Native Tests - gRPC Logs Raw logs

^ doesn't look like it corresponds to what actually happened @gsmet @gastaldi

@geoand geoand dismissed gsmet’s stale review April 8, 2021 06:52

The Vertx 4 branch has now been merged

@geoand
Copy link
Contributor Author

geoand commented Apr 8, 2021

For good measure, I'll rebase this PR onto main

@gsmet
Copy link
Member

gsmet commented Apr 8, 2021

@geoand yeah for the bot, it's because I cancelled the build to prioritize the 1.13.1 backport PR. I should probably handle this at the bot level.

@gsmet gsmet merged commit d356ba1 into quarkusio:main Apr 8, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 8, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 8, 2021
@geoand
Copy link
Contributor Author

geoand commented Apr 8, 2021

@gsmet Gotcha.

I was going to rebase the PR, but since you merged it, no need :)

@geoand geoand deleted the rr-config branch April 8, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants