-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of @DisableIfBuiltWithGraalVMOlderThan on test methods #16285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zakkak want to give it a shot? |
gastaldi
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test Failures⚙️ jvm-linux-jdk11📦 integration-tests/mailer# Tests: 1
+ Success: 0
- Failures: 0
- Errors: 1
! Skipped: 0 ❌
|
geoand
force-pushed
the
disable-if-build-on-method
branch
from
April 6, 2021 19:51
555dd7a
to
b961c8d
Compare
zakkak
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for checking! |
Failing Jobs
Test Failures⚙️ jvm-linux-jdk11📦 integration-tests/mailer# Tests: 1
+ Success: 0
- Failures: 0
- Errors: 1
! Skipped: 0 ❌
|
geoand
force-pushed
the
disable-if-build-on-method
branch
from
April 7, 2021 07:49
b961c8d
to
5d06a05
Compare
geoand
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Apr 7, 2021
#16304 should have fixed the CI issue. I rebased and force-pushed |
Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/vault-agroal# Tests: 4
+ Success: 3
- Failures: 0
- Errors: 1
! Skipped: 0 ❌
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #16216 (comment)