Add workaround to generated projects for maven.compiler.parameters problem in IntelliJ IDEA #16261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/devtools
quarkus-bot
bot
added
the
area/platform
|
@famod shouldn't we apply a similar fix for Gradle (maybe a stupid question)? |
I'm not using IntelliJ IDEA myself but I guess Gradle integration is an entirely different story? |
|
Is |
famod
reviewed
Apr 6, 2021
| @@ -118,6 +118,9 @@ | |||
| <plugin> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>$\{compiler-plugin.version}</version> | |||
| <configuration> | |||
| <parameters>$\{maven.compiler.parameters}</parameters> | |||
There was a problem hiding this comment.
Maybe we should render a comment what this is for? Otherwise it may look strange/inconsistent when you don't know the details.
There was a problem hiding this comment.
I am not sure we should add comment for this, else we would need to comment the whole pom.xml :)
There was a problem hiding this comment.
Perhaps a minor comment with the https://youtrack.jetbrains.com/issue/IDEA-201496 link would be nice to have, just so we can remember to remove it when that bug is fixed :)
There was a problem hiding this comment.
@gastaldi I added it, but it seems they are deleted during the smart pom merge :-/
There was a problem hiding this comment.
Hm, I think the maven-model-merger ignores comments from the non-dominant side.
I'd say that maybe having the comment in the template should be enough for now until we fix this.
Looking at the other side, also I don't see a reason that we'll want this parameter to be false, so maybe removing the maven.compiler.parameters property and make it fixed to true directly in the plugin configuration should be good enough ™️ :)
Yes it's all plugged on the same templates.. |
Test Failures⚙️ devtools-linux-jdk11📦 integration-tests/devtools# Tests: 106
+ Success: 104
- Failures: 2
- Errors: 0
! Skipped: 0❌
|
ia3andy
force-pushed
the
fix-16141
branch
2 times, most recently
from
d26e956 to
0124909
Compare
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka# Tests: 10
+ Success: 8
- Failures: 0
- Errors: 2
! Skipped: 0❌
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka# Tests: 10
+ Success: 8
- Failures: 0
- Errors: 2
! Skipped: 0❌
|
|
This is such a stable CI, could we call that a strike @gsmet 😂? |
…oblem in IntelliJ IDEA Fixes quarkusio#16141
|
OK just rebased I hope the CI will not crash this time |
Failing Jobs - Building 3c854e5
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka✖ ✖ |
|
Unless there are strong cons, I propose to backport this because 2.0.0.Final will probably take a while. |
famod
approved these changes
Apr 12, 2021
gastaldi
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16141