Disable kafka-snappy tests for versions of GraalVM older than 21.0 #16236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially the test is skipped if the GraalVM version used to build the native binary was older than the version specified in the new @DisableIfBuiltWithGraalVMOlderThan annotation
cescoffier
approved these changes
Apr 5, 2021
geoand
added
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by Introducing the ability to skip native tests if GraalVM version is too old
Essentially the test is skipped if the GraalVM version used to build the
native binary was older than the version specified in the new
@DisableIfBuiltWithGraalVMOlderThanannotation.This is accomplished by recording the GraalVM version in the
quarkus-artifact.propertiesfile (this file was introduced to support
@QuarkusIntegrationTest) and readingthe necessary data in a new JUnit 5
ExecutionConditionimplementation.Fixes: #16129