Upload the Surefire reports as artifacts #16229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/infra-automation
famod
reviewed
Apr 4, 2021
| if: failure() | ||
| with: | ||
| name: surefire-reports-native-windows-${{matrix.category}} | ||
| path: "**/target/surefire-reports/TEST-*.xml" |
There was a problem hiding this comment.
Suggested change
| path: "**/target/surefire-reports/TEST-*.xml" | |
| path: "**/target/*-reports/TEST-*.xml" |
to also catch failsafe reports. Although not all jobs execute failsafe tests, it wouldn't hurt to use the broader pattern everywhere.
There was a problem hiding this comment.
PS: this should work for Gradle:
**/build/test-results/test/TEST-*.xml
There was a problem hiding this comment.
Ok, I generalized a bit but not exactly sure how things will go. We will have to experiment with it.
Test Failures⚙️ native-linux-Security3📦 integration-tests/vault-app# Tests: 2
+ Success: 0
- Failures: 0
- Errors: 1
! Skipped: 1❌
|
|
Looks like it worked OK. Lucky to have one test failure for this PR :). |
|
Will merge to see how it goes for the other pull requests. |
|
Nice! Another gsmetbot. 😁 |
|
@famod yeah, this is the first feature for which having the bot in Java was really handy as I was able to reuse some existing library namely https://maven.apache.org/surefire/surefire-report-parser/index.html . |
|
Really helpful! I think a link to the failed job would make things even more convenient. |
|
Yeah, the thing is that it's not so easy and it would require a lot more experiments as things are a bit decoupled in the GH API. I'll release the code hopefully next week so people will be able to play with it and add new features if they wish. |
|
@gsmet I think it would be nice if the Tests Failures were set as the first PR comment, for easier access |
|
How about displaying the tests summary as a table? Tests: 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a pet project I'm working on.