Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keycloak Test Module to support code flow tests #16213

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

sberyozkin
Copy link
Member

This PR does a few minor improvements to the newly introduced Keycloak test module nicely done by @cemnura :

  • Customizes realm, client ids, makes sure it can support both service and web-app tests, work over plain HTTP
  • Updated the docs
  • Updated the dev code flow tests in extensions/oidc/deployment to use it

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes

@geoand
Copy link
Contributor

geoand commented Apr 5, 2021

@sberyozkin Hi,

can you please squash the commits?

Thanks

@sberyozkin
Copy link
Member Author

sberyozkin commented Apr 5, 2021

@geoand Hi Georgios, oh sorry, will do, by the way, I wanted to give it a quick try and see if this test module can also be used to test quarkus-oidc-client, so I'll look into it a bit and make sure the commits are squashed as well, thanks

@geoand
Copy link
Contributor

geoand commented Apr 5, 2021

Cool, thanks for the info

@sberyozkin sberyozkin force-pushed the keycloak_test_module_updates branch from bde73d3 to 38f253f Compare April 6, 2021 16:59
@sberyozkin
Copy link
Member Author

@gastaldi @pedroigor Just pushed another update - where I switched oidc-client-filter/deployment to use the new test module and also did a minor doc update.
@gsmet thanks very much for your help with github related issues :-) (for the record, I've messed up the history by accidentally rebasing while pulling George's updates) - please cancel it if it is too much for CI at this point - I'll restart later - not an urgent PR

@sberyozkin
Copy link
Member Author

OK, it is all green so I'll go ahead with the merge :-)

@sberyozkin sberyozkin merged commit 4ab1d19 into quarkusio:main Apr 6, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 6, 2021
@sberyozkin sberyozkin deleted the keycloak_test_module_updates branch April 6, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants