-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle avro generator in gradle #16201
Conversation
6ae9bea
to
f40c05c
Compare
Seems like you need to:
:) |
right! I tried to do it manually but it didn't work :) I will run the script. |
f40c05c
to
d003de1
Compare
@famod I don't understand what is going on.. I ran the script on my machine (both new version working on mac os, and current version in a container) and the pom does not change but ci is complaining.. do you have an idea? |
@glefloch I'll have a look! |
d003de1
to
13f8864
Compare
I added diff --git a/integration-tests/gradle/pom.xml b/integration-tests/gradle/pom.xml
index bfd5a86c8e..e5ab1bcb4a 100644
--- a/integration-tests/gradle/pom.xml
+++ b/integration-tests/gradle/pom.xml
@@ -94,21 +94,11 @@
<artifactId>quarkus-resteasy</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy-jsonb</artifactId>
- <version>${project.version}</version>
- </dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-test-devtools</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-vertx</artifactId>
- <version>${project.version}</version>
- </dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-arc-deployment</artifactId>
@@ -200,32 +190,6 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy-jsonb-deployment</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>*</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-vertx-deployment</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- <scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>*</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
<!-- END update-dependencies.sh -->
</dependencies> So in CI, the script is removing vert.x and jsonb... Does that make any sense? |
Hm, looking at what you added/changed in this PR, I have to say I understand why the script is removing those dependencies: neither of the two deps was added to any of the |
Well I think it make sense. I tried reverting all modification in the pom running the script again but, I have the same result. I will drop those new dependency manually |
13f8864
to
ab2596c
Compare
...and now I can also replicate the behavior locally. First the script didn't change anything for me locally either because I called it via |
I'm running it in |
Then you should see the same effect as in CI. |
@@ -32,7 +32,7 @@ | |||
public static final String QUARKUS_GENERATED_SOURCES = "quarkus-generated-sources"; | |||
public static final String QUARKUS_TEST_GENERATED_SOURCES = "quarkus-test-generated-sources"; | |||
// TODO dynamically load generation provider, or make them write code directly in quarkus-generated-sources | |||
public static final String[] CODE_GENERATION_PROVIDER = new String[] { "grpc" }; | |||
public static final String[] CODE_GENERATION_PROVIDER = new String[] { "grpc", "avpr", "avsc" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's really bad that we need this list. Can we access classpath resources in here?
I saw that avro code generator was integrated in the main branch.
This add support in the gradle plugin.