Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the codestarts artifactId #16177

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

aloubyansky
Copy link
Member

This fixes the artifactId containing the codestarts templates which is referenced from the extension descriptors.
And also adds code to the extension descriptor generator to complete and validate the configured codestarts artifact coordinates.

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/codestarts area/config area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/google-cloud-functions area/kotlin area/logging area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/resteasy-classic area/rest area/scala area/spring Issues relating to the Spring integration area/websockets labels Apr 1, 2021
@aloubyansky
Copy link
Member Author

@gsmet this is for 1.13.x only. The main branch has diverged.

@gsmet
Copy link
Member

gsmet commented Apr 1, 2021

@aloubyansky test failures look related:

Error:  Failures: 
Error:    ExtensionProcessorTest.testKotlinMetadata:45 
expected: "io.quarkus:quarkus-platform-descriptor-json"
but was : "io.quarkus:quarkus-platform-descriptor-json::jar:999-SNAPSHOT"
Error:    ExtensionProcessorTest.testRESTEasyMetadata:27 
expected: "io.quarkus:quarkus-platform-descriptor-json"
but was : "io.quarkus:quarkus-platform-descriptor-json::jar:999-SNAPSHOT"

@gsmet gsmet added this to the 1.13.1.Final milestone Apr 1, 2021
@aloubyansky aloubyansky force-pushed the 1.13-quarkus-descriptor-json branch from 3ddbe97 to e2523a9 Compare April 1, 2021 12:01
@aloubyansky
Copy link
Member Author

Should be fixed now.

@gsmet gsmet merged commit 46c6d36 into quarkusio:1.13 Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/codestarts area/config area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/funqy area/google-cloud-functions area/kotlin area/logging area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/rest area/resteasy-classic area/scala area/spring Issues relating to the Spring integration area/websockets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants