Use Vert.x Buffer for OIDC requests #16157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
oidc_web_client_no_chunked_enc
branch
from
24b5745 to
9e66209
Compare
cescoffier
approved these changes
Mar 31, 2021
|
@cescoffier, thanks, I've removed one unused property which I forgot to remove in one of the recent PRs and just restored it - otherwise the backport would be more difficult as this property is not in |
|
So should this be merged? |
|
@geoand Hey, sorry, just stepped outside for an eve walk :-). Yeah, let me merge it |
|
Cool!
…On Wed, Mar 31, 2021 at 11:08 PM sberyozkin ***@***.***> wrote:
@geoand <https://github.com/geoand> Hey, sorry, just stepped outside for
an eve walk :-). Yeah, let me merge it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16157 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDP4RB46HL47L45JJEFTTGN6MXANCNFSM42FCZYHQ>
.
|
|
@gsmet Hi Guillaume - sorry - if this PR proves a bit messy to backport :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16151
This PR uses
sendBufferas opposed tosendFormas the later does not setContent-Length.I did a tiny optimization during the encoding process as the only few standard parameters which are used for the OIDC requests do not require the encoding