Make sure all the project modules are loaded into workspace in case the root pom does not declare any #16138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/devtools
gsmet
reviewed
Apr 1, 2021
| final Model model = readModel(pomFile); | ||
| cachedModels.put(pomFile.getParent(), model); | ||
| private LocalProject loadAndCache(Path pomFile) throws BootstrapMavenException { | ||
| final LocalProject model = new LocalProject(readModel(pomFile), workspace); |
There was a problem hiding this comment.
Minor but maybe you should rename the variable for more clarity?
| if (workspace.getCurrentProject() == null) { | ||
| load(null, currentProjectPom); | ||
| private LocalProject loadProjectWithModules(Path projectPom, String skipModule) throws BootstrapMavenException { | ||
| final LocalProject project = model(projectPom); |
There was a problem hiding this comment.
The model() method should probably be renamed too?
| @@ -138,6 +138,27 @@ public void loadWorkspaceWithDirBreaks() throws Exception { | |||
| assertEquals(4, ws.getProjects().size()); | |||
| } | |||
|
|
|||
| @Test | |||
| //@Disabled | |||
…he root pom does not declare any
aloubyansky
force-pushed
the
workspace-loading
branch
from
a1c5b43 to
5d974ba
Compare
|
@gsmet all done |
gsmet
approved these changes
Apr 1, 2021
gsmet
added
the
triage/waiting-for-ci
|
Just in case, this is the failure |
|
@michalszynkiewicz could you have a look at the failure above? |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
@geoand do you have time to take a look at the failure? It's the test you modified. |
|
I'll take a look |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Apr 1, 2021
|
Here it is #16187 |
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Apr 3, 2021
Relates to: quarkusio#16138 (comment) (cherry picked from commit eef926f)
8 tasks
|
@aloubyansky it looks like this needs to be backported to |
|
Right |
|
@gsmet I am re-adding the backport label |
|
It looks like the milestone has already been set to 1.13.1.Final |
|
It's actually been backported already to 1.13. |
|
Ah, OK |
juazugas
pushed a commit
to juazugas/quarkus
that referenced
this pull request
Sep 30, 2021
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the bootstrap Maven workspace discovery when the current project is located deep in the module hierarchy and the root pom doesn't happen to list any modules.