Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about quarkus-security dependency #16045

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Add a note about quarkus-security dependency #16045

merged 1 commit into from
Mar 26, 2021

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin sberyozkin requested a review from gastaldi March 26, 2021 10:32
gastaldi
gastaldi approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor

BTW if the dependency is required for all items, shouldn't it be the first item?

@sberyozkin
Copy link
Member Author

sberyozkin commented Mar 26, 2021 •
edited
Loading

@gastaldi Hi George - all the existing mechanisms will have it hence I added it only in this sub-section - because here the users may want to go without smallrye-jwt and other sec extensions. I was thinking for a moment to put it somewhere in the main security.adoc page but then thought the users would copy it even if it is already fetched with smallrye-jwt or any other sec extension...
Are you OK with this clarification ?

@sberyozkin
Copy link
Member Author

sberyozkin commented Mar 26, 2021 •
edited
Loading

@gastaldi May be it is worth creating a small subsection instead titled Custom Security and note that if you go totally your own way then add this dependency and proceed from there...

@sberyozkin
Copy link
Member Author

Ignore me please - it is also needed for bouncy castle, etc, so I'll put something on top of that doc with the note

@sberyozkin sberyozkin force-pushed the doc_quarkus_security_dep branch from 537b0c3 to c1183b2 Compare March 26, 2021 14:32
@sberyozkin
Copy link
Member Author

Hey @gastaldi I've moved it to the top and have verified the links work - does it look all right ? if some text needs to be tweaked then please let me know

gastaldi
gastaldi approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sberyozkin sberyozkin merged commit e08a716 into quarkusio:main Mar 26, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 26, 2021
@sberyozkin sberyozkin deleted the doc_quarkus_security_dep branch March 26, 2021 14:58
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.13.1.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @gastaldi @gsmet