Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UserCountryNotSetValidatorLocaleTest fail #16022

Merged

Conversation

tttomat19
Copy link
Contributor

Fix UserCountryNotSetValidatorLocaleTest fail if System.getProperty("user.country") is already null. (when LANG=C and openjdk in linux).

The goal of the test is to ensure that code works when user.country is undefined by removing it artificially by calling System.clearProperty . But if build system already has user.country undefined (e.g. when environment property LANG=C) the test fails.

…user.country") is already null. (when LANG=C and openjdk in linux).
@quarkus-bot quarkus-bot bot added the area/hibernate-validator Hibernate Validator label Mar 25, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 25, 2021
@gastaldi gastaldi merged commit 23b3435 into quarkusio:main Mar 26, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-validator Hibernate Validator triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants