Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - fix an issue with bridge methods and generics #15983

Merged
merged 1 commit into from
Mar 24, 2021
Merged

ArC - fix an issue with bridge methods and generics #15983

merged 1 commit into from
Mar 24, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 24, 2021

No description provided.

@mkouba mkouba requested a review from manovotn March 24, 2021 10:22
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 24, 2021
@mkouba mkouba force-pushed the arc-bridge-methods-generics-fix branch from 3d46f22 to b6b7159 Compare March 24, 2021 12:08
@mkouba mkouba force-pushed the arc-bridge-methods-generics-fix branch from b6b7159 to a04bc6c Compare March 24, 2021 12:47
manovotn
manovotn approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 24, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Mar 24, 2021

The test failure in Native Tests - Security3 is very likely unrelated:

2021-03-24T14:00:23.5365602Z Caused by: io.smallrye.mutiny.TimeoutException
2021-03-24T14:00:23.5366948Z 	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:58)
2021-03-24T14:00:23.5368451Z 	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:61)
2021-03-24T14:00:23.5369892Z 	at io.quarkus.vault.runtime.client.VertxVaultClient.exec(VertxVaultClient.java:161)
2021-03-24T14:00:23.5372018Z 	at io.quarkus.vault.runtime.client.VertxVaultClient.exec(VertxVaultClient.java:154)
2021-03-24T14:00:23.5374036Z 	at io.quarkus.vault.runtime.client.VertxVaultClient.post(VertxVaultClient.java:107)
2021-03-24T14:00:23.5376047Z 	at io.quarkus.vault.runtime.client.VertxVaultClient.post(VertxVaultClient.java:101)
2021-03-24T14:00:23.5384129Z 	at io.quarkus.vault.runtime.client.authmethod.VaultInternalUserpassAuthMethod.login(VaultInternalUserpassAuthMethod.java:14)
2021-03-24T14:00:23.5387045Z 	at io.quarkus.vault.runtime.VaultAuthManager.login(VaultAuthManager.java:159)
2021-03-24T14:00:23.5388890Z 	at io.quarkus.vault.runtime.VaultAuthManager.vaultLogin(VaultAuthManager.java:145)
2021-03-24T14:00:23.5390803Z 	at io.quarkus.vault.runtime.VaultAuthManager.login(VaultAuthManager.java:116)
2021-03-24T14:00:23.5392542Z 	at io.quarkus.vault.runtime.VaultAuthManager.login(VaultAuthManager.java:95)
2021-03-24T14:00:23.5394493Z 	at io.quarkus.vault.runtime.VaultAuthManager.getClientToken(VaultAuthManager.java:79)
2021-03-24T14:00:23.5498486Z 	at io.quarkus.vault.runtime.VaultKvManager.readSecret(VaultKvManager.java:36)

@mkouba mkouba merged commit d5c3817 into quarkusio:main Mar 24, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@mkouba @manovotn