Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - fix disposer method resolution #15975

Merged
merged 1 commit into from
Mar 24, 2021
Merged

ArC - fix disposer method resolution #15975

merged 1 commit into from
Mar 24, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 24, 2021

  • disposed parameter with wildcard does not match correctly

@mkouba mkouba requested a review from manovotn March 24, 2021 07:36
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 24, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Mar 24, 2021

See also https://groups.google.com/g/quarkus-dev/c/2Dm3NT9e7Vs

@mkouba
ArC - fix disposer method resolution
fddece7 
- disposed parameter with wildcard does not match correctly
@mkouba mkouba force-pushed the disposer-wildcard-fix branch from e295cb1 to fddece7 Compare March 24, 2021 07:42
manovotn
manovotn approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 24, 2021
@gsmet
Copy link
Member

gsmet commented Mar 24, 2021

CI Failures are unrelated, merging.

@gsmet gsmet merged commit 8e7f5ea into quarkusio:main Mar 24, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 24, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
@gsmet gsmet modified the milestones: 1.13.1.Final, 1.11.7.Final Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.7.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @gsmet @manovotn