Support GraalVM 21.1 LocalizationFeature #15971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerboaa can you give this a try? |
|
@geoand OK. I'll test it and report back here. |
|
@geoand Seems to work fine for me. +1 |
|
Cool, thanks for checking! I rebased the PR onto |
gsmet
approved these changes
Mar 24, 2021
gsmet
added
the
triage/waiting-for-ci
|
FWIW I started a GH workflow to test this PR with latest graal as well: |
|
@gsmet can we get this backported to 1.13? This will help us get the upstream graal CI mostly green (see oracle/graal#3272 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like in GraalVM 21.1, some things changed in the localication support.
This change makes Quarkus work with both the current incarnation of that support and what is planned for 21.1
Fixes: #15962