Fixes quarkus-platform native TS config #15929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
gsmet
requested changes
Mar 22, 2021
| @@ -195,6 +171,96 @@ protected CuratedApplication curateApplication(QuarkusBootstrapMojo mojo) throws | |||
| } | |||
| } | |||
|
|
|||
| protected AppArtifact managingProject(QuarkusBootstrapMojo mojo) { | |||
| if (mojo.appArtifactCoords() == null) { | |||
| return null; | |||
There was a problem hiding this comment.
So if it's an external artifact, you return null here? What's bothering me a bit is that it wasn't set before so I'm not sure to understand why it's now set in the case that was already existing?
There was a problem hiding this comment.
Sure. When the appArtifact is configured, the current project is used as the environment for the build and tests. That's the meaning behind the managingProject. It's either null or the current project. Setting it to null is equivalent to not setting it at all.
gsmet
approved these changes
Mar 23, 2021
|
I think it's best not backporting it for now. Let's fix this for 1.14, it has been broken for a while anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quarkus-platform TS config was using native-image goal of the quarkus-maven-plugin that was recently removed.
native-imageallowed to configure an alternative artifact as the app artifact in place of the current project. Which is how imported tests are run. With thenative-imagegoal removed there is no way to configure the alternative app artifact.This PR adds
appArtifactparameter to the QuarkusBootstrapMojo that is equivalent to the removed from the NativeImageMojo one.