Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutiny 0.15.0 support #15920

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Mutiny 0.15.0 support #15920

merged 1 commit into from
Apr 2, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Mar 22, 2021

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/mutiny area/smallrye labels Mar 22, 2021
@jponge
Copy link
Member Author

jponge commented Mar 22, 2021

Currently a draft PR (Mutiny 0.15.0 hasn't been released yet).

Operator logging is a new addition to the extension work.

@jponge jponge force-pushed the mutiny-0.15.0 branch 2 times, most recently from 7803060 to a0301e9 Compare March 30, 2021 15:06
@jponge jponge marked this pull request as ready for review March 30, 2021 15:09
@jponge
Copy link
Member Author

jponge commented Mar 30, 2021

Mutiny has been released

@jponge jponge requested review from cescoffier and geoand March 30, 2021 15:09
geoand
geoand approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jponge jponge requested a review from gsmet March 30, 2021 15:55
gsmet
gsmet requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is incorrect. mutiny-vertx.version has been replaced by smallrye-reactive-utils.version. Will fix and force push.

@jponge @gsmet
Mutiny 0.15.0 integration
9c4dfd5 
Brings integration to the new Multi / Uni logging operator.

Uses the latest Vert.x client bindings aligned with Mutiny 0.15.0.
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2021
@jponge
Copy link
Member Author

jponge commented Apr 1, 2021

@gsmet what did you do to the commit?

@gsmet
Copy link
Member

gsmet commented Apr 1, 2021

I just adjusted the correct variable. I think you got it wrong when you rebased (you probably had a conflict).

@gsmet
Copy link
Member

gsmet commented Apr 1, 2021

This one: https://github.com/quarkusio/quarkus/pull/15920/files#diff-2b7d71809e1063e0d0411cbe30d606e12b984790680195567e7b8bde0d078e3fR54 .

@jponge
Copy link
Member Author

jponge commented Apr 1, 2021

Ok thanks

@gsmet gsmet merged commit b6646d7 into quarkusio:main Apr 2, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 2, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/mutiny area/smallrye
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@jponge @gsmet @cescoffier @geoand