Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime initialize amazon-services classes using j.u.Random #15897

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Mar 19, 2021

@gsmet another one for #14904. This one fixes integration-tests/amazon-services. Thoughts?

@jerboaa jerboaa changed the title Runtime initialize amazon-services classes using j.u.Ramdom Runtime initialize amazon-services classes using j.u.Random Mar 19, 2021
@jerboaa jerboaa force-pushed the runtime-init-aws-services-21.1 branch from 6df32c0 to eebe26e Compare March 19, 2021 18:48
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added a small question that needs clarification.

@jerboaa jerboaa force-pushed the runtime-init-aws-services-21.1 branch from eebe26e to 0ea2949 Compare March 22, 2021 10:38
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The gist of it is that you should add the rules in the extension providing the class.

@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 22, 2021

OK, thanks!

@gsmet gsmet merged commit a9fadaf into quarkusio:main Mar 23, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 23, 2021
@gsmet
Copy link
Member

gsmet commented Mar 23, 2021

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants