Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entirely skipped enforcer in infinispan-client IT and resolve violations #15841

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Fix entirely skipped enforcer in infinispan-client IT and resolve violations #15841

merged 1 commit into from
Mar 18, 2021

Conversation

famod
Copy link
Member

@famod famod commented Mar 18, 2021

This skipped way too many checks:

[WARNING]
Dependency convergence error for com.fasterxml.jackson.core:jackson-core:2.12.1 paths to dependency are:
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-io.quarkus:quarkus-resteasy:999-SNAPSHOT
    +-io.quarkus:quarkus-vertx-http:999-SNAPSHOT
      +-io.quarkus:quarkus-vertx-core:999-SNAPSHOT
        +-io.vertx:vertx-core:3.9.5
          +-com.fasterxml.jackson.core:jackson-core:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.fasterxml.jackson.core:jackson-core:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.1
        +-com.fasterxml.jackson.core:jackson-core:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-com.fasterxml.jackson.core:jackson-core:2.11.0

[WARNING]
Dependency convergence error for com.thoughtworks.xstream:xstream:1.4.16 paths to dependency are:
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-io.quarkus:quarkus-junit5:999-SNAPSHOT
    +-com.thoughtworks.xstream:xstream:1.4.16
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.thoughtworks.xstream:xstream:1.4.15

[WARNING]
Dependency convergence error for com.fasterxml.jackson.core:jackson-annotations:2.12.1 paths to dependency are:
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.fasterxml.jackson.core:jackson-annotations:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-com.fasterxml.jackson.core:jackson-annotations:2.11.0

[WARNING]
Dependency convergence error for com.fasterxml.jackson.core:jackson-databind:2.12.1 paths to dependency are:
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.fasterxml.jackson.core:jackson-databind:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-org.infinispan:infinispan-server-hotrod:12.0.1.Final
    +-org.infinispan:infinispan-server-core:12.0.1.Final
      +-com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.1
        +-com.fasterxml.jackson.core:jackson-databind:2.12.1
and
+-io.quarkus:quarkus-integration-test-infinispan-client:999-SNAPSHOT
  +-com.fasterxml.jackson.core:jackson-databind:2.11.0

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability. See above detailed error message.
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found Banned Dependency: org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec:jar:1.1.1.Final
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

...and (as expected) the minimal deployment dependencies were missing as well.

I don't think the exclusions I added have actually changed the relevant semantics. Everything is still passing.
But then again: I'm not an Infinispan expert and I'm not sure what this "jboss marshalling" comment was about.

@quarkus-bot quarkus-bot bot added the area/infinispan Infinispan label Mar 18, 2021
@@ -128,17 +171,6 @@
</resource>
</resources>
<plugins>
<plugin>
<artifactId>maven-failsafe-plugin</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is already handled in IT parent. With this change, the native IT ran just fine in my fork.

@gsmet gsmet merged commit 534ae37 into quarkusio:main Mar 18, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 18, 2021
@famod famod deleted the fix-it-infinispan-client branch March 18, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants