Avoid class initializations more aggressively in the Hibernate ORM extension #15822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/hibernate-orm
yrodiere
reviewed
Mar 22, 2021
There was a problem hiding this comment.
It looks good except for some missing tests in non-ORM modules (envers, etc.).
But I'd really like a more future-proof approach when it comes to tests... if maintainers have to think of adding a test every time they add a constant, you can bet that eventually they will forget to. I made a suggestion to avoid that (to some extent) below.
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java
Outdated
Show resolved
Hide resolved
...deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateUserTypeProcessor.java
Outdated
Show resolved
Hide resolved
...eployment/src/main/java/io/quarkus/hibernate/envers/deployment/HibernateEnversProcessor.java
Show resolved
Hide resolved
...rm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmAnnotations.java
Show resolved
Hide resolved
|
What's the status of this? |
|
Seems like I have to add the tests. I will try to get it done before tonight. |
yrodiere
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
@Sanne @gsmet Done. I pushed two additional commits to regroup all class name constants in the same util class, so that hopefully someone adding a new constant will add it there and will automatically have their constant tested.
I tried adding DotName.createSimple to the forbidden APIs, but we cannot do that because there are valid uses of that method with dynamic arguments (class names retrieved from annotations).
So I guess this will have to do.
|
Rebased to fix a conflict. |
gsmet
added
the
triage/waiting-for-ci
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment# Tests: 16
+ Success: 14
- Failures: 1
- Errors: 0
! Skipped: 1❌
|
…gle class So that we can test them easily.
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, this takes better advantage of the Forbidden API plugin to avoid unnecessarily initialization of classes, which is particularly important in this extension.
Fixes #15728