Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: inject attributes in template extensions methods #15772

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 16, 2021

@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Mar 16, 2021
@gsmet gsmet added this to the 1.13 - main milestone Mar 16, 2021
@gsmet
Copy link
Member

gsmet commented Mar 16, 2021

CI is failing with:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-1:compile (default-compile) on project qute-generator: Compilation failure
Error:  /home/runner/work/quarkus/quarkus/independent-projects/qute/generator/src/main/java/io/quarkus/qute/generator/ExtensionMethodGenerator.java:[680,49] cannot find symbol
Error:    symbol:   class Param
Error:    location: class io.quarkus.qute.generator.ExtensionMethodGenerator
Error:  -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-1:compile (default-compile) on project qute-generator: Compilation failure
/home/runner/work/quarkus/quarkus/independent-projects/qute/generator/src/main/java/io/quarkus/qute/generator/ExtensionMethodGenerator.java:[680,49] cannot find symbol
  symbol:   class Param
  location: class io.quarkus.qute.generator.ExtensionMethodGenerator

@gsmet
Copy link
Member

gsmet commented Mar 16, 2021

What is weird is that the other JDK builds are not failing. @mkouba rings a bell or it's a glitch?

@mkouba
Copy link
Contributor Author

mkouba commented Mar 16, 2021

Looks like some odd compilation problem... it should be OK now (I've verified locally with JDK8).

@mkouba
Copy link
Contributor Author

mkouba commented Mar 17, 2021

Hm, failures look unrelated...

2021-03-16T23:41:37.4611272Z [ERROR] Failures: 
2021-03-16T23:41:37.4612087Z [ERROR]   BasicKubernetesTest.assertDependencies:108 
2021-03-16T23:41:37.4613106Z Expecting directory:
2021-03-16T23:41:37.4615880Z   /home/runner/work/quarkus/quarkus/integration-tests/kubernetes/quarkus-standard-way/target/quarkus-prod-mode-test16070550556064391413/build-result/quarkus-app/lib/main
2021-03-16T23:41:37.4617428Z not to contain any files matching the given filter but found some:
2021-03-16T23:41:37.4626314Z   [/home/runner/work/quarkus/quarkus/integration-tests/kubernetes/quarkus-standard-way/target/quarkus-prod-mode-test16070550556064391413/build-result/quarkus-app/lib/main/io.quarkus.quarkus-kubernetes-client-internal-999-SNAPSHOT.jar]

@gsmet gsmet merged commit f420f91 into quarkusio:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute: Template attributes in template extensions
2 participants