Add ability to customise DevServices URL #15749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Mar 16, 2021
| System.out | ||
| .println("[INFO] H2 database started in TCP server mode; server status: " + tcpServer.getStatus()); | ||
| String connectionUrl = "jdbc:h2:tcp://localhost:" + tcpServer.getPort() + "/mem:" | ||
| + datasourceName.orElse("default") | ||
| + ";DB_CLOSE_DELAY=-1"; | ||
| + ";DB_CLOSE_DELAY=-1" + additionalArgs.toString(); |
There was a problem hiding this comment.
Ah ah, I was going to ask about DB_CLOSE_DELAY.
gsmet
approved these changes
Mar 16, 2021
| } | ||
| String jdbcUrl = container.getJdbcUrl(); | ||
| if (additionalArgs.length() > 0) { | ||
| if (jdbcUrl.contains("?")) { |
There was a problem hiding this comment.
MSSQL is actually a bit special in this regard. The parameters are not separated using ? and &. Please have a look at https://github.com/testcontainers/testcontainers-java/blob/master/modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java#L94-L95.
There was a problem hiding this comment.
@knutwannheden would you be willing to prepare a PR to adjust that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15579