-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary test dependencies #15741
Conversation
Don't trust my script? 😄
If the runtime counterparts are used: yes absolutely! For the same reason we enrich all other ITs with those minimal deployment dependencies: To ensure Maven builds the respective deployment module(s) before the IT module. |
GH actions are broken ATM: https://www.githubstatus.com/incidents/s654n76c1bwr |
@@ -18,13 +18,13 @@ allprojects { | |||
|
|||
subprojects{ | |||
repositories { | |||
mavenCentral() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this reminds me of something I wanted to ask you anyway: In CI we use .github/mvn-settings.xml
for Maven, which uses the Google EU central mirror, but I have seen Gradle tests downloading stuff from central instead.
So I guess something is missing to pass it to Gradle in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't know, if this is a central mirror, I think this could be ok. I will add it too, in case of mavenCentral()
failure, it will be used.
89d19db
to
2f2a5bb
Compare
I've just rebased this branch to trigger CI now that GH Actions are back to normal. I hope you don't mind. 🙂 |
2f2a5bb
to
baed9f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not sure if anyone else should have a look before merging. I'll leave this up to you @glefloch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very useful, thanks for taking the time to do that!
This branch leverage all dependencies used in gradle test IT. Addresses task number 2 from #15686.
@famod, let's see how build goes :). I manually updated the
pom.xml
.In the
pom.xml
, there are some-deployment
dependencies that are not used in any gradle project (likequarkus-grpc-deployment
,quarkus-kotlin-deployment
) should we keep them?