Ensure that quarkus-kubernetes does not pollute the runtime classpath

[geoand]

Fixes: #15705

[aloubyansky]

Just to clarify, quarkus-kubernetes-client will be the only one providing io.fabrik8:kubernetes-client, the rest of the extensions depending on the quarkus-kubernetes-client-internal will not. Is this how it is intended to be?

[geoand]

Just to clarify, quarkus-kubernetes-client will be the only one providing io.fabrik8:kubernetes-client, the rest of the extensions depending on the quarkus-kubernetes-client-internal will not. Is this how it is intended to be?

Yes, exactly

[geoand]

Actually, I still need to try something

[geoand]

Tried what I had in mind and it works just fine

[geoand]

Some tests are failing :(

[aloubyansky]

I guess it's a compile dependency which isn't then provided at runtime. Not isolated enough.

[geoand]

I thought that adding

        <dependency>
            <groupId>io.fabric8</groupId>
            <artifactId>kubernetes-client</artifactId>
        </dependency>

to quarkus-kubernetes-client-deployment-internal would be enough - but it's still failing with:

Caused by: java.lang.NoClassDefFoundError: io/fabric8/kubernetes/client/KubernetesClient
        at io.quarkus.kubernetes.client.deployment.KubernetesClientBuildStep.process(KubernetesClientBuildStep.java:16)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

and I don't see why...

[aloubyansky]

Because it appears as a transitive dependency. Only direct provided dependencies (of the app or test) are supposed to be collected. If it has to be present at build time then it should just be a build-time (compile) dependency. Build time-only dependencies should be used with caution though, to make sure they are actually not required at runtime.

[geoand]

I am sure I am missing something from what you described, but I don't really know how to solve this case TBH...

If there is some way I can include io.fabric8:kubernetes-client in the quarkus-kubernetes-client-deployment-internal (therefore build-time) module, then everything should be OK, as the client will be present at build time when it's needed. At runtime it won't be present, unless the quarkus-kubernetes-client extensions brings it in.

[aloubyansky]

You haven't actually added that dependency to the quarkus-kubernetes-client-deployment-internal. So, if i got you right, just add a direct compile dependency on io.fabric8:kubernetes-client in the quarkus-kubernetes-client-deployment-internal.

[geoand]

You haven't actually added that dependency to the quarkus-kubernetes-client-deployment-internal. So, if i got you right, just add a direct compile dependency on io.fabric8:kubernetes-client in the quarkus-kubernetes-client-deployment-internal.

That is what I am trying locally and unfortunately I am seeing the same error.

[aloubyansky]

I'll have a look into this a bit later today.

[geoand]

I pushed what I am doing locally as well.

[geoand]

I'll have a look into this a bit later today.

I'm looking as well to try and understand what is going on.

[aloubyansky]

Is farbik8 client necessary to build the internal runtime module?

[geoand]

Is farbik8 client necessary to build the internal runtime module?

Yes, unfortunately it is

[geoand]

Looking into it a little more closely, it seems that this is caused by the fact that io.quarkus.kubernetes.client.runtime.KubernetesClientUtils is being loaded by the System ClassLoader.

[aloubyansky]

Doesn't it mean that the fabrik8 client is actually required at runtime? At least from the classloading perspective?

[geoand]

Doesn't it mean that the fabrik8 client is actually required at runtime? At least from the classloading perspective?

From a classloader perspective, yes.

However the problem is this:

When I simple do mvn package on a project tha contains the quarkus-kubernetes, everything works as expected (io.quarkus.kubernetes.client.runtime.KubernetesClientUtils is loaded from the augmentation ClassLoader.)
The problem I mentioned above only seems to happen with the QuarkusProdModeTest, so I am really not sure what to make of it...

[geoand]

There is probably a horrible hack I can do to make it work, let me check

[geoand]

There is probably a horrible hack I can do to make it work, let me check

It didn't work.

I am really baffled by this because the only place this fails is in the QuarkusProdModeTest...

[geoand]

I am really baffled by this because the only place this fails is in the QuarkusProdModeTest...

I think I know why this is happening...

[geoand]

It should now be OK

[geoand]

I also added a test to make sure this does not happen again

[aloubyansky]

Great @geoand, thanks!

[geoand]

👍🏼