Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Kafka config producer #15680

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Polish Kafka config producer #15680

merged 1 commit into from
Mar 13, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 12, 2021 •
edited
Loading

  • Remove lambdas
  • Remove useless final
  • Use proper CDI scopes
  • Use CDI injection instead of Config lookup

@geoand geoand force-pushed the kafka-props-producer-cleanup branch from 921a844 to a02ad54 Compare March 12, 2021 15:07
@geoand geoand mentioned this pull request Mar 12, 2021
Merged
Base automatically changed from master to main March 12, 2021 15:55
@geoand geoand force-pushed the kafka-props-producer-cleanup branch 2 times, most recently from 0d1bf54 to d437f2a Compare March 12, 2021 21:13
@geoand
Polish Kafka config producer
3213039 
* Remove lambdas
* Use proper CDI scopes
* Use CDI injection instead of Config lookup
@geoand geoand force-pushed the kafka-props-producer-cleanup branch from d437f2a to 3213039 Compare March 13, 2021 08:23
@geoand geoand marked this pull request as ready for review March 13, 2021 09:12
@geoand geoand requested a review from cescoffier March 13, 2021 09:43
@geoand geoand merged commit da37da8 into quarkusio:main Mar 13, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 13, 2021
@geoand geoand deleted the kafka-props-producer-cleanup branch March 15, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/kafka
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @cescoffier