Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have ORM handle MappedSuperClass with generics in a more reliable way #15676

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Mar 12, 2021

This was super tricky to identify; the actual fix is the one liner in b0d3824 .

The other commits to prevent similar regressions in the future.

Fixes #15588

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Mar 12, 2021
Base automatically changed from master to main March 12, 2021 15:55
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi merged commit 57925bf into quarkusio:main Mar 13, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 13, 2021
@famod
Copy link
Member

famod commented Mar 14, 2021

Since the fix is small enough, I propose to backport this (in case there is going to be another 1.12).
Just remove the label in case you disagree. 🙂

@Sanne Sanne deleted the MappedSuperClassFix branch March 15, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.hibernate.AnnotationException happens randomly
4 participants