ArC - enable implementing all types of interception with single method #15633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Mar 11, 2021
mkouba
commented
- resolves @PostConstruct interceptor method returning Object works only if it's private #15570
manovotn
requested changes
Mar 11, 2021
| @@ -103,6 +91,22 @@ | |||
| } | |||
| } | |||
|
|
|||
| private MethodInfo validateSignature(MethodInfo method) { | |||
| List<Type> parameters = method.parameters(); | |||
| if (parameters.size() != 1 || !parameters.get(0).name().equals(DotNames.INVOCATION_CONTEXT)) { | |||
There was a problem hiding this comment.
Shouldn't we also allow ArcInvocationContext?
There was a problem hiding this comment.
That's a good point but I don't think it would work right now... let me check.
There was a problem hiding this comment.
Hm, this would actually require some more work, because we also generate the interceptor beans that implement javax.enterprise.inject.spi.Interceptor.intercept(InterceptionType, T, InvocationContext) etc. We can create a feature request though. Currently, you would need to cast the InvocationContext inside the interceptor method. @manovotn WDYT?
There was a problem hiding this comment.
Fair enough, it just occurred to me when I saw the code :)
manovotn
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.