Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC guide: syntax highlighting for proto example, small fixes #15582

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Mar 9, 2021

gRPC guide:

  • syntax highlighting for proto example using javascript keyword trick, now it is just plain text
  • small fixes: removal of ``` and text to properties metadata change

@@ -64,7 +64,7 @@ Alternatively to using the `generate-code` goal of the `quarkus-maven-plugin`, y
Let's start with a simple _Hello_ service.
Create the `src/main/proto/helloworld.proto` file with the following content:

[source]
[source,javascript]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why javascript?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe [source,protobuf] will work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf is not recognized, plain text is rendered. That's why I used javascript keyword to get some highlighting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see.

I checked the available languages and SASS looks interesting:
image

@michalszynkiewicz michalszynkiewicz merged commit 0c99222 into quarkusio:master Mar 9, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants