Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive routes - fail if void method and no param can end the response #15572

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Reactive routes - fail if void method and no param can end the response #15572

merged 1 commit into from
Mar 9, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 9, 2021

@mkouba mkouba requested a review from cescoffier March 9, 2021 09:53
cescoffier
cescoffier requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a small typo. The rest looks good.

extensions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/Route.java Outdated Show resolved Hide resolved
@mkouba mkouba requested a review from cescoffier March 9, 2021 12:35
@cescoffier cescoffier added this to the 1.13 - master milestone Mar 9, 2021
@cescoffier cescoffier merged commit 2405149 into quarkusio:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Vert.x Routes Not Working when using Void methods
2 participants
@mkouba @cescoffier