Add DevServices support for DB2 and MSSQL #15561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
gsmet
requested changes
Mar 11, 2021
|
|
||
| If you want to use DevServices then all you need to do is include the relevant extension for the type of database you want (either reactive or | ||
| JDBC, or both), and don't configure a database URL, username and password, Quarkus will provide the database and you can just start | ||
| coding without worrying about config. | ||
|
|
||
| If you are using a proprietary database such as DB2 or MSSQL you will need to accept the license agreement. To do this | ||
| create a `src/main/resources/container-license-acceptance.txt` files in your project and add a line with the image | ||
| name and tag of the database. By default Quarkus uses the default image for the current version of testcontainers, if |
There was a problem hiding this comment.
Suggested change
| name and tag of the database. By default Quarkus uses the default image for the current version of testcontainers, if | |
| name and tag of the database. By default Quarkus uses the default image for the current version of Testcontainers, if |
| create a `src/main/resources/container-license-acceptance.txt` files in your project and add a line with the image | ||
| name and tag of the database. By default Quarkus uses the default image for the current version of testcontainers, if | ||
| you attempt to start Quarkus the resulting failure will tell you the exact image name in use for you to add to the | ||
| file. |
There was a problem hiding this comment.
Even with that, I would have added a small example.
| </dependency> | ||
| <dependency> | ||
| <groupId>com.microsoft.sqlserver</groupId> | ||
| <artifactId>mssql-jdbc</artifactId> |
There was a problem hiding this comment.
Do we really need the JDBC driver dependency? Asking that because we really need the user to use the extension.
There was a problem hiding this comment.
This is on the -deployment side, the user still needs the extension to actually use it.
We need the driver because testcontainers uses it to create a connection and run a query to determine when the DB is ready to accept requests.
There was a problem hiding this comment.
Ah OK, that's what I was unsure of. Thanks for the explanation!
This allows them to be automatically started if the license is accepted. No tests as I am not sure if we want to be accepting the license as part of our build.
stuartwdouglas
force-pushed
the
propietary-databases
branch
from
21035b6 to
fac43a1
Compare
|
Done |
gsmet
approved these changes
Mar 12, 2021
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows them to be automatically started if the license
is accepted.
No tests as I am not sure if we want to be accepting the
license as part of our build.
Fixes: #15540